search

vinnymac / PokeNurse

💉 A tool for Pokémon Go to aid in transferring and evolving Pokémon
284 stars 55 forks source link

MaxCP is wrong #146

Closed iPaulis closed 7 years ago

iPaulis commented 7 years ago

There seems to be a real problem with the MaxCP maths. The bug is not completely consistent, happened with some pokemon and not with others. MaxCP is not completely mistaken because it corresponds with the previous CP of the pokemon. I mean, my guess is that MaxCP seems to be showing MaxCP-1*PowerUp, so one step less than it should.

Examples: max cp max cp 2 max cp 3 max cp 4

iPaulis commented 7 years ago

So now I found 2 cases where MaxCP was correct, exactly as real CP, so I dont know why it shows 1 power up less CP sometimes and correctly other times. max cp 5 max cp 6

vinnymac commented 7 years ago

Sounds like an off by 1 issue. The protobuf files have changed, and I am certain some of our info is out of date, so maybe the max CPs were part of that. I know some of the max CP logic came from blossoms java code, so maybe we can see if that has been updated to match the newer versions of pogo.

@mackhankins any ideas?

Rplus commented 7 years ago

The formula is correct. And this issue due to the Level limitation is trainer's level +2 in API,
but it is trainer's level +1.5 in APP interface.

ref: http://www.pokemongochamp.com/bug-in-buddy-system-allows-to-power-up-pokemon-beyond-max-level/

vinnymac commented 7 years ago

I am not so certain that this should be fixed. I will reopen it if someone has a good argument. Reference: https://github.com/Wolfsblvt/BlossomsPokemonGoManager/issues/477