vinnymac / PokeNurse

💉 A tool for Pokémon Go to aid in transferring and evolving Pokémon

284 stars 55 forks source link

Update available evolutions based on the candy received after a transfer #174

Open YesThatAllen opened 7 years ago

YesThatAllen commented 7 years ago

When counting candies to evolves, keep in mind that we get one back for every evolve.

eg: if I want to evolve 10 Pidgies in a row, I need 12 for the first, then the one I get back after the evolution, meaning I need only 11 for the next.

10x11+1=111 candies.. as opposed to 10x12=120 candies.

Once I have 23 candies (and at least 2 Pidgey), I can make two Pidgeottos.

Currently, PokeNurse not show that I have two evolutions available until I had 24 candies.

This is also directly related to the conversation at https://github.com/vinnymac/PokeNurse/issues/101

hacknug commented 7 years ago

I think I've fixed it. Let me make sure it's right and I can submit a PR for this.

vinnymac commented 7 years ago

Nice, I think we have a lot more info available then we used to, I am hoping this is just some math we need to do. I'll review the PR if you make one.

hacknug commented 7 years ago

This was just some math, indeed. Was waiting to hear your thoughts on it before the PR. Will try to submit it later today so you can review and maybe @YesThatAllen can confirm it's working as expected.

YesThatAllen commented 7 years ago

Happy to, looking forward to it.

hacknug commented 7 years ago

Here you go #202

YesThatAllen commented 7 years ago

202 gets the math right in the preview,

screenshot_4231

36 pidgey need 36*11 = 396 +1 = 397 total. (This is correct.)

However, the Evolves column is still off.

227-1=226/11=20.5= 20 evolves

hacknug commented 7 years ago

My bad. Didn't thought about changing anything else besided those tooltips. Will check it when I get home.