Closed hacknug closed 7 years ago
What goodness does this bring?
Add display options to details modal
Showing the IV components (15/14/13) etc to the modal would be a nice add
It would show you if a mon uses a different costume/skin than default, is male/female/genderless, is shiny or not, and what's its form (Unowns have 28 different ones).
I don't think we show gender anywhere, so maybe we can use the gender symbols for it and put it in the modal somewhere. You can create checkboxes in the GitHub markdown using brackets [] in a list if you wanted to keep track of what you've done.
Good usage of node-pogo-protos by the way, idk if we are missing any edge cases but I am sure we will find out.
This would be a lot harder, but i think it is possible for us to show the actual HP in the modal.
The actual hp are in the pokemon info from pogo, so I don't think it's difficult to add a new display with that info
Harder in terms of amount of work. It'll be more work to design an HP gauge that represents the current HP than to display a symbol in the modal for gender.
I really don't understand why we're talking about HP lol
@hacknug just discussing features that you could easily add. This is good as it stands imo.
Is there anything else you would like to see added to this?
Now I understand haha. I meant features related to the display options this PR adds. I will draw some icons for gender and shiny like the ones in the last game update and show screenshots once I have them on my dev build then.
Their are some changes I might make to the image loading, but it looks good.
To-do
Is there anything else you would like to see added to this?