Waving

[Redarion]

This pull provide 2 new columns.

The first one is made by 2 parameters:

-NWD = No Waving Damage (per Sec) is the actual DPS done by your pokemon per second just by spamming your quick attack -PWD = Perfect Waving Damage (per Sec) is the actual DPS done by your pokemon per second using also your charge moves.

The second one is -PWD% = Perfect Waving Damage (per Sec) Rating is the actual rating based on the best Waving damage of the current pokemon.

Been made just by 2 characters, this last parameter is supposed to be used as a renaming pattern in future change.

[vinnymac]

I think this change is really cool. We might want to make rows toggle so that people can show/hide the ones they want before we add this, unless it fits the app. We should discuss what we plan on doing for columns in the future here.

[Redarion]

The toggle thing is something a bit out of my league. If someone can take that or at least give me hints on how to make it, I can also modify this branch to make it work along that feature

[hacknug]

My two cents on what would be my ideal roadmap:

• Port things to Material UI
• Add ability to tweak columns visibility the right way
• Add ability to have different setups (different visible columns for each one)
• Add all kinds of column options for all kind of scenarios and users
• Enjoy Pokémon GO

With all this said, we could still add things the wrong way and hide them using CSS. We could even add some checkboxes on the app settings to disable any given column. My problem with this approach is it would probably have an impact on performance because everything would still be there (it wouldn't if we only add a few more columns).

Hiding the name column in the child species table would be as easy as adding this to our CSS file:

tr.child thead th:nth-child(4),
tr.child tbody td:nth-child(4) {
  display: none;
}