search

vinodsr / node-red-contrib-tuya-smart-device

a node-red module for managing tuya smart devices
https://flows.nodered.org/node/node-red-contrib-tuya-smart-device
MIT License
43 stars 15 forks source link

fine-tunig ver 5.0.1 #115

Closed msillano closed 1 year ago

msillano commented 1 year ago

Use context

Node-red application with 20+ devices, production

Fine-tuning goals: 1) Reduction of ERROR messages for connection/disconnection: In production, connection, and disconnection are normal events, not ERROR, managed at a higher level with automatic strategies (standby, dynamic random timeouts, etc.).

2) reduction and anonymization of the log: to be able to exchange logs, load shedding

3) added new COMMAND:, SET_DATA_EVENT (both|event-data|event-dp-refresh)

4) Smooth handling of CONNECT/DISCONNED/ERROR

5) other minor changes

vinodsr commented 1 year ago

Thanks for the changes and suggestions.

There has been lot of unwanted comments in the code , which is not adhering to the coding standards. I am agreeing to 95 % of the changes that you recommend. So I had started to make changes in another branch as per your PR. You can see the changes feature/improve-code-base.

Yet to complete it. I was away from work for some personal reasons. Will try to complete it soon.

Thanks alot.

msillano commented 1 year ago

Yes, a lot of comments: I try to be clear :).

This is the production application (in the debug pad the data echo):

[image: image.png]

And here is an example of SET_DATA_EVENT use: https://github.com/msillano/tuyaDEAMON-applications/blob/main/daemon.energy/README.md#1a-verbose-devices-too-much-data

Best regards m.s.

Il giorno mer 7 giu 2023 alle ore 13:48 Vinod S R @.***> ha scritto:

Closed #115 https://github.com/vinodsr/node-red-contrib-tuya-smart-device/pull/115.

— Reply to this email directly, view it on GitHub https://github.com/vinodsr/node-red-contrib-tuya-smart-device/pull/115#event-9458047287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJKXUMBB5JKGFAGYZAARNTXKBS7VANCNFSM6AAAAAAXA7E35Y . You are receiving this because you authored the thread.Message ID: <vinodsr/node-red-contrib-tuya-smart-device/pull/115/issue_event/9458047287 @github.com>

-- Marco Sillano

http://www.o2xdl.org https://github.com/msillano?tab=repositories http://web.tiscali.it/sicoclu/index.htm http://web.tiscali.it/GioBridge/ https://www.facebook.com/marco.sillano