search

vinodsr / node-red-contrib-tuya-smart-device

a node-red module for managing tuya smart devices
https://flows.nodered.org/node/node-red-contrib-tuya-smart-device
MIT License
47 stars 15 forks source link

4.1.1 update #69

Closed msillano closed 3 years ago

msillano commented 3 years ago

The modified file is src/tuya-smart-device.js

Hope that can help to build a better and more robust tuya-smart-device node. Best regards m.s.

vinodsr commented 3 years ago

Can you please use prettier plugin in vscode. The diff looks unable to identify the changes done. You can see it yourself

VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

vinodsr commented 3 years ago

The readme file also changed alot with unnecessary statements. many of the existing blocks are removed

msillano commented 3 years ago

I don't use VS, so I used the online prettier with defaults: https://prettier.io, The file https://github.com/msillano/node-red-contrib-tuya-smart-device/blob/master/src/tuya-smart-device.js is now updated.

Tested using another (maybe better performing?) comparison sw (notepad ++ & compare plugin), This way you can easily point out the differences.

About readme, The document at https://github.com/msillano/node-red-contrib-tuya-smart-device is not the original README changed!

It is a NEW document that introduces the change I made to code: enough to read it.

Best regards m.s.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

Auto closing the issue