search

vinodsr / node-red-contrib-tuya-smart-device

a node-red module for managing tuya smart devices
https://flows.nodered.org/node/node-red-contrib-tuya-smart-device
MIT License
43 stars 15 forks source link

Allow "Device Key" to be specified as a secret #77

Closed foxylion closed 2 years ago

foxylion commented 2 years ago

Hi, I added some tuja nodes to my flows, but I noticed that the tuya nodes store the "Device Key" within the flow.json file. This has the negative side effect that I can no longer publish this file into a Git repository as I would store secrets into the repository.

Is it possible that the tuya nodes store the secret into the flows_cred.json file? See https://nodered.org/docs/creating-nodes/credentials for details.

vinodsr commented 2 years ago

Hi,

I added some tuja nodes to my flows, but I noticed that the tuya nodes store the "Device Key" within the flow.json file.

This has the negative side effect that I can no longer publish this file into a Git repository as I would store secrets into the repository.

Is it possible that the tuya nodes store the secret into the flows_cred.json file?

See https://nodered.org/docs/creating-nodes/credentials for details.

Thanks for the feedback. Let me check the feasibility of this. I don't want to break the current working model as well.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

foxylion commented 2 years ago

Hi, this feature would still be helpful!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

foxylion commented 2 years ago

As previously said. I would still love to see this feature. :-)

vinodsr commented 2 years ago

@foxylion

After checking the compatibility , i am planning to introduce a check box "Store as credentials" which will store the deviceId and deviceKey in the credentials file.

This will give flexibility as some users still want to store the id in the flows file so that they can easily import export.

Hope this will serve your request.

I had started the development of this.

foxylion commented 2 years ago

@vinodsr that would be awesome! Really appreciate it :)

vinodsr commented 2 years ago

Released Version 5.0.0 Please check and let me know .

foxylion commented 2 years ago

@vinodsr I just checked it. Works perfectly, thank you!