search

vinsol-spree-contrib / spree_marketing

Spree extension that allow a lot of reports synced with Mailchimp to help you in creating different subscribers list on Mailchimp. This extension provides reports like "Most Selling Products", "Abandoned Carts", "Most searched keywords", etc. to give better insights.
BSD 3-Clause "New" or "Revised" License
7 stars 18 forks source link

Gibbon response fixes #87

Closed SergeyMell closed 5 years ago

vinay-mittal commented 5 years ago

@SergeyMell I am verifying this pull request. The changes you have done in Gibbon API requests are not given on their README. I will hit these requests and verify the responses as given by you and proceed ahead.

SergeyMell commented 5 years ago

Thank you @vinay-mittal. I didn't check the readme but I've just tested the requests and run into this issue. Please, let me know if any additional data required.

SergeyMell commented 5 years ago

@vinay-mittal, I've fixed the one missed body. Please, take a look. By the way, did you have a chance to test my changes?

vinay-mittal commented 5 years ago

@SergeyMell I verified this change and seems right. They changed it in Gibbon version 3+. It is specified here . And in master branch gibbon version used is 3.2.0, so it spree versions less than 3. Gibbon version is 2.3 so it will not work there.

Thanks for the contribution. :)