search

vinsol-spree-contrib / spree_marketing

Spree extension that allow a lot of reports synced with Mailchimp to help you in creating different subscribers list on Mailchimp. This extension provides reports like "Most Selling Products", "Abandoned Carts", "Most searched keywords", etc. to give better insights.
BSD 3-Clause "New" or "Revised" License
7 stars 18 forks source link

Mailchimp contacts for not registered users #88

Open SergeyMell opened 5 years ago

SergeyMell commented 5 years ago

Implemented creating mailchimp contacts for not registered users (Abandoned carts list)

vinay-mittal commented 5 years ago

@SergeyMell The change you have done as far as i am understanding here is If a guest user comes and adds products without logging in and signing up. Then you want to include it in Abandoned List, but there is a case when user just adds the item and does not proceed to checkout further, in that case we don't even have its email and according to the change you have done it will be invalid as well.

SergeyMell commented 5 years ago

@SergeyMell The change you have done as far as i am understanding here is If a guest user comes and adds products without logging in and signing up. Then you want to include it in Abandoned List, but there is a case when user just adds the item and does not proceed to checkout further, in that case we don't even have its email and according to the change you have done it will be invalid as well.

No, it will not because I'm using pluck(:email).compact. So it will remove empty emails

vinay-mittal commented 5 years ago

@SergeyMell I will verify this thing by running you code. And get back to you.

vinay-mittal commented 5 years ago

@SergeyMell Have you been able to change the test cases as mentioned above?