search

vinsol-spree-contrib / spree_product_subscriptions

SpreeCommerce product subscription extension lets customers subscribe for a product and get it delivered at the same time every week, month or year over a predefined period of time.
http://vinsol.com/spreecommerce-subscription
MIT License
10 stars 57 forks source link

Update for 3.2.x and Rails 5 #50

Closed pikender closed 7 years ago

pikender commented 7 years ago

Fixed core functionality of assigning subscription details failing due to strong params change of not following hash behaviour Fixed redirect_to :back Deprecation Warning Fixed Specs failing for Mail Deliveries Added ActionMailer Queue Adapter as test and checked queue length http://stackoverflow.com/a/26275654/306686

dgreen22 commented 7 years ago

@pikender Hi there - I'm still getting the same error message.

` Bundler could not find compatible versions for gem "spree_core": In snapshot (Gemfile.lock): spree_core (= 3.2.0.rc2)

 In Gemfile:
spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc2, which depends on
  spree_core (= 3.2.0.rc2)

spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc2, which depends on
  spree_core (= 3.2.0.rc2)

spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc2, which depends on
  spree_core (= 3.2.0.rc2)

spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc2, which depends on
  spree_core (= 3.2.0.rc2)

spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc2, which depends on
  spree_core (= 3.2.0.rc2)

spree_auth_devise (~> 3.2.0.beta) was resolved to 3.2.0.beta, which depends on
  spree_core (< 4.0, >= 3.1.0)

spree_auth_devise (~> 3.2.0.beta) was resolved to 3.2.0.beta, which depends on
  spree_core (< 4.0, >= 3.1.0)

spree_product_subscriptions was resolved to 3.1.0, which depends on
  spree_core (~> 3.1.0)

Running "bundle update" will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict. `

If I run bundle update I get: 


  In Gemfile:
    spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc1, which depends on
      spree_core (= 3.2.0.rc1)

    spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc1, which depends on
      spree_core (= 3.2.0.rc1)

    spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc1, which depends on
      spree_core (= 3.2.0.rc1)

    spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc1, which depends on
      spree_core (= 3.2.0.rc1)

    spree (~> 3.2.0.rc1) was resolved to 3.2.0.rc1, which depends on
      spree_core (= 3.2.0.rc1)

    spree_gateway (~> 3.2.0.beta) was resolved to 3.2.0.beta, which depends on
      spree_core (< 4.0, >= 3.1.0)

    spree_gateway (~> 3.2.0.beta) was resolved to 3.2.0.beta, which depends on
      spree_core (< 4.0, >= 3.1.0)

    spree_product_subscriptions was resolved to 3.1.0, which depends on
      spree_core (~> 3.1.0)```

Appreciate your help with this.
pikender commented 7 years ago

@dgreen22 can you share your Gemfile and Gemfile.lock ?

Also share output of bundle list | grep product.

are you upgrading an existing Spree store ?

The project was having Gemfile.lock earlier which was locked at 3.1.x which is deleted in this PR so should resolve issues for further releases.

spree_product_subscriptions should resolve to 3.2.0 as changed here

dgreen22 commented 7 years ago

@pikender This worked perfectly. I forgot to add the branch to the gemfile. Thank you again!