search

vinszent / gnome-twitch

Enjoy Twitch on your GNU/Linux desktop
http://gnome-twitch.vinszent.com
Other
440 stars 40 forks source link

Request for a new version #359

Closed Aqa-Ib closed 6 years ago

Aqa-Ib commented 6 years ago

Hello. I am asking for a new version because bug #356 leaved the program on a unusable state on every distribution out there. Submiting a new version will make package maintainers to upgrade the program into a usable state again.

Thank you, regards.

vinszent commented 6 years ago

Hi! So I kinda don't want to tag a new release because a lot has changed from 0.4.1 and a there is a lot more to change, so releasing a 0.4.2 will be really half baked. It should be possible for maintainers to just patch their packages with the fix, which I think is better.

Aqa-Ib commented 6 years ago

Oh, I understand. Then I will report a bug in my distribution to see if it is possible for the maintainer to apply the patch.

Thanks!

TingPing commented 6 years ago

The Flatpak has already had the backport for a bit.

I think it makes a lot of sense to just make an 0.4.2 which is 0.4.1 + this backport. You don't have to release off of HEAD.

TingPing commented 6 years ago

Here is a patch that applies to 0.4.1 for any other packages btw: https://raw.githubusercontent.com/flathub/com.vinszent.GnomeTwitch/master/0001-Use-new-Twitch-API-URL-over-SSL.patch

vinszent commented 6 years ago

Sure I can create a release branch.

TingPing commented 6 years ago

@vinszent Oh, please include https://github.com/vinszent/gnome-twitch/commit/6bee8bc0d1626087340138e66225d55ebe9d498e too.

Aqa-Ib commented 6 years ago

Fixed on debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898768

vinszent commented 6 years ago

@TingPing I've tagged v0.4.2 on the release-v0.4.2 branch, hopefully that works for you.

TingPing commented 6 years ago

Forgot to include it in the appdata file.

vinszent commented 6 years ago

Right.... well not much I can do now. v0.4.1 isn't there either anyways, so I'll try remember to update it next time.

TingPing commented 6 years ago

Oh, Meson file wasn't even bumped either.