search

vintagedave / firemonkey-container

Automatically exported from code.google.com/p/firemonkey-container
92 stars 34 forks source link

Rename FMXContainer.pas to fmxembedded.FMXContainer.pas, update packa… #6

Closed savanniekerk closed 8 years ago

savanniekerk commented 8 years ago

…ges,

add package for XE8

vintagedave commented 8 years ago

Hi @savanniekerk! Thanks for the pull request.

The request has several things:

It's quite a lot all at once, I'm afraid - better to have individual pull requests. The reason is you can't separate out specific changes.

Re:

  1. I have pushed packages for XE8 and Seattle, and also fixed a bug in the XE7 packages.
  2. I'm not sure about the "FMXEmbedded" prefix. Instead I used "Parnassus", my company (http://parnassus.co)
  3. EurekaLog - I guess that was in there by accident, but I don't use EL and don't want to add it to the projects.

So I think this should match your changes even though I haven't used your pull. Thankyou anyway!

savanniekerk commented 8 years ago

Hi David,

No problem.

Will break it up next time into some smaller requests.

Yes, the unit prefix was added for Seattle, a similar unit existed in dclfmxstd230 library. Eureka log was on by accident.

Will keep it cleaner next time around.

Thanks and Regards

Steve van Niekerk

From: David Millington [mailto:notifications@github.com] Sent: 07 December 2015 07:34 PM To: vintagedave/firemonkey-container firemonkey-container@noreply.github.com Cc: savanniekerk savanniekerk@live.com Subject: Re: [firemonkey-container] Rename FMXContainer.pas to fmxembedded.FMXContainer.pas, update packa. (#6)

Hi @savanniekerk https://github.com/savanniekerk ! Thanks for the pull request.

The request has several things:

It's quite a lot all at once, I'm afraid - better to have individual pull requests. The reason is you can't separate out specific changes.

Re:

  1. I have pushed packages for XE8 and Seattle, and also fixed a bug in the XE7 packages.
  2. I'm not sure about the "FMXEmbedded" prefix. Instead I used "Parnassus", my company (http://parnassus.co)
  3. EurekaLog - I guess that was in there by accident, but I don't use EL and don't want to add it to the projects.

So I think this should match your changes even though I haven't used your pull. Thankyou anyway!

Reply to this email directly or view it on GitHub https://github.com/vintagedave/firemonkey-container/pull/6#issuecomment-162601823 . https://github.com/notifications/beacon/ACUPNpc-bs-sI7_YC5wgVy7bm4rmUjMSks5pNbqSgaJpZM4GwBUZ.gif