vintagepc / MK404

A functional Simulator for Prusa (Mini/Einsy) Rambo based printers
https://vintagepc.github.io/MK404/
GNU General Public License v3.0
72 stars 9 forks source link

263 klipper take 2 #282

Closed vintagepc closed 3 years ago

vintagepc commented 4 years ago

Description

Fixes some timing issues with Klipper and --skew-correction

Behaviour/ Breaking changes

Should have no net effect, but improves stability with skew correction.

Have you tested the changes?

Yes, locally was able to finally complete 3 benchys.

Other

Anything else you'd like us to know, or that may be beneficial if we need to maintain your contribution down the road?

Linked issues:

codecov-io commented 4 years ago

Codecov Report

Merging #282 (0b57a33) into master (04fae8f) will decrease coverage by 0.15%. The diff coverage is 56.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   89.49%   89.33%   -0.16%     
==========================================
  Files         140      140              
  Lines        6518     6546      +28     
==========================================
+ Hits         5833     5848      +15     
- Misses        685      698      +13     
Impacted Files Coverage Δ
parts/components/HD44780.h 100.00% <ø> (ø)
parts/Board.cpp 79.29% <44.82%> (-3.39%) :arrow_down:
parts/components/uart_pty.cpp 79.60% <50.00%> (-0.40%) :arrow_down:
MK404.cpp 89.13% <100.00%> (+0.04%) :arrow_up:
parts/components/HD44780.cpp 78.60% <100.00%> (+0.05%) :arrow_up:
parts/components/HD44780GL.cpp 100.00% <100.00%> (ø)
utility/Config.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04fae8f...0b57a33. Read the comment docs.