search

vintagepc / MK404

A functional Simulator for Prusa (Mini/Einsy) Rambo based printers
https://vintagepc.github.io/MK404/
GNU General Public License v3.0
72 stars 9 forks source link

Return a flashair IP from the SD #290

Closed vintagepc closed 3 years ago

vintagepc commented 3 years ago

Description

Feature request to return an IP as if the simulated SD card is a FlashAir card.

Behaviour/ Breaking changes

Returns a data block with the IP if probed with the correct parameters to CMD48 (Extension register read)

Have you tested the changes?

Yes, works locally with official MK3 branch where support has been restored. Also added test functionality to the test_SD card to read this block as part of the test.

Linked issues:

codecov-io commented 3 years ago

Codecov Report

Merging #290 (f67f594) into master (ef089ab) will increase coverage by 0.00%. The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         140      140           
  Lines        6561     6575   +14     
=======================================
+ Hits         5863     5876   +13     
- Misses        698      699    +1
Impacted Files Coverage Δ
parts/components/SDCard.h 100.00% <ø> (ø)
parts/components/SDCard.cpp 93.31% <92.85%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef089ab...f67f594. Read the comment docs.