search

vintasoftware / django-ai-assistant

Integrate AI Assistants with Django to build intelligent applications
https://vintasoftware.github.io/django-ai-assistant/
MIT License
204 stars 12 forks source link

Add `django_auth` to ninja API #94

Closed pamella closed 2 months ago

pamella commented 2 months ago

Issues

Resolves #57

Description

Screencast from 17-06-2024 18:16:31.webm

pamella commented 2 months ago

LGTM, but we should provide an easy way for the dev to use token auth too. Do you think it's enough to allow the user to set the kwargs of API or provide a init_api function that we'll call on django_ai_assistant/api/views.py? See: #55

I'd say the init_api function can be a more robust approach. Maybe that will also reflect on the client side, we may need to provide a way for devs to set up client interceptors as well.

fjsj commented 2 months ago

Good input. I added that to https://github.com/vintasoftware/django-ai-assistant/issues/55

fjsj commented 2 months ago

conflict here @pamella

pamella commented 2 months ago

conflict here @pamella

I'll fix the conflicts once #93 is merged

pamella commented 2 months ago

The conflicts have been fixed

fjsj commented 2 months ago

@amandasavluchinske please make sure to sync with main before writing more tests.