vintasoftware / django-react-boilerplate

Django 5, React, Bootstrap 5 with Python 3 and Webpack project boilerplate
MIT License
1.97k stars 479 forks source link

Replace django-naomi with Mailhog #464

Closed jhgv closed 3 years ago

jhgv commented 4 years ago

Works only when developing using Docker Closes #450

Steps to test

Steps to reproduce (if appropriate):

Types of changes

Checklist:

vanessa commented 4 years ago

What do you think about keeping django-naomi (or using another Django alternative like file backend) for those who don't want to use docker? We use it with docker but we'd force people who don't in case they want to just send some emails.

jhgv commented 4 years ago

@vanessa I think it is better to use another alternative because django-naomi is deprecated. This other alternative you mentioned might be better and there is no need to install another lib.

vanessa commented 4 years ago

@jhgv Ah, nice. Didn't know about django-naomi being deprecated. I'm just worried about having the user with no option other than use docker just to spin up this service. If we don't need to worry about that, then you can ignore this :sweat_smile:

rvlb commented 3 years ago

Installing Mailhog locally seems to be pretty straightforward, maybe we could point to this in our readme. Happy to add it there if that's the case.

Non-docker users must also configure postgres, redis, etc, so I think this shouldn't be a big issue.