Remove instructions to install pip-tools globally - Githubissues

vintasoftware / django-react-boilerplate

Django 5, React, Bootstrap 5 with Python 3 and Webpack project boilerplate

MIT License

1.97k stars 479 forks source link

Remove instructions to install pip-tools globally #490

Closed osantana closed 4 years ago

osantana commented 4 years ago

The compile_install_requirements target on Makefile installs pip-tools in active virtualenv.

Description

Add pip install pip-tools in compile_install_requirements target on Makefile forcing the installation of this package in the active virtualenv.
Change the README.md file with the new instructions (and update the latest Python version).
Add a cosmetic change on .gitignore to make explicit that .idea is a directory.

Motivation and Context

Not everybody uses pip-tools in their own projects and it would be not desirable to install it globally.

Types of changes

[x] Improvement
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires documentation updates.
[x] I have updated the documentation accordingly.
[ ] My change requires dependencies updates.
[ ] I have updated the dependencies accordingly.

osantana commented 4 years ago

Thanks @vanessa! I really have no idea how to fix node-related issues haha :)

vanessa commented 4 years ago

@osantana Can you merge master into your branch? That'll fix the issue.