vintasoftware / django-react-boilerplate

Django 5, React, Bootstrap 5 with Python 3 and Webpack project boilerplate
MIT License
1.97k stars 479 forks source link

Fix Makefile rules #515

Closed heliomeiralins closed 4 years ago

heliomeiralins commented 4 years ago

Description

Fix the test, testreset, dockertest and dockertestreset rules. We also fix the clean_examples rule and add commands to remove exempleapp lines from the urls.py and settings/base.py files.

Motivation and Context

test and testreset are broken because they are run from the parent directory of the manage.py. To fix we pass the Django project folder to it. dockertest and dockertestreset are broken because the Dockerfile already sets the WORKDIR as the Django project folder.

Steps to reproduce (if appropriate):

Create a new project following the instructions and run the rules. test and testreset fails to find any tests. After the fix -> runs 10 tests. dockertest and dockertestreset fail because the path of the manage.py is wrong. After the fix -> run 10 tests. clean_examples fail due to wrong manage.py path

Types of changes

Checklist: