Fix isLoading state in .pending to be true, in redux store - Githubissues

vintasoftware / django-react-boilerplate

Django 5, React, Bootstrap 5 with Python 3 and Webpack project boilerplate

MIT License

1.94k stars 466 forks source link

Fix isLoading state in .pending to be true, in redux store #624

Closed jalilbm closed 10 months ago

jalilbm commented 10 months ago

Description

This PR fixes the isLoading state in the .pending action of the restCheckReducer to correctly indicate when data is being loaded.

Motivation and Context

The isLoading state was incorrectly set to false during pending API calls, which could lead to misleading UI behavior.

Screenshots (if appropriate):

Steps to reproduce (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires documentation updates.
[ ] I have updated the documentation accordingly.
[ ] My change requires dependencies updates.
[ ] I have updated the dependencies accordingly.

fjsj commented 10 months ago

thanks @jalilbm merged.