vinted / elasticsearch-dsl-rs

Strongly typed Elasticsearch DSL written in Rust
Apache License 2.0
198 stars 18 forks source link

Renaming scroll_id to _scroll_id. #222

Closed fulmicoton closed 1 year ago

fulmicoton commented 1 year ago

The scroll id is returned as _scroll_id in the elasticsearch JSON payload.

See https://www.elastic.co/guide/en/elasticsearch/reference/current/search-search.html#search-api-response-body

codecov-commenter commented 1 year ago

Codecov Report

Merging #222 (be3ccc4) into master (1b86b9a) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         159      159           
  Lines        9809     9809           
=======================================
  Hits         8373     8373           
  Misses       1436     1436           
Impacted Files Coverage Δ
src/search/response/search_response.rs 100.00% <ø> (ø)
fulmicoton commented 1 year ago

thank you!