Add include and exclude to terms aggregation

vinted / elasticsearch-dsl-rs

Strongly typed Elasticsearch DSL written in Rust

Apache License 2.0

198 stars 18 forks source link

Add include and exclude to terms aggregation #254

Closed dean-shaff closed 5 months ago

dean-shaff commented 10 months ago

Add include and exclude parameters to terms aggregation: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-terms-aggregation.html#_filtering_values_4

dean-shaff commented 10 months ago

There is no rush whatsoever!

buinauskas commented 10 months ago

@dean-shaff cool, so make sure to rebase on latest first and then submit the change if possible. There were some breaking changes in Rust 1.73.0 that required updating the code. Otherwise, CI tests would fail.

buinauskas commented 9 months ago

@dean-shaff sorry, I've been away and could only come back to this now. Could you split this PR into two? One for collapse, the other one for includes/excludes in terms aggregation?

dean-shaff commented 9 months ago

sorry for the delay; I'll create PRs for each thing.

buinauskas commented 5 months ago

Closing, implemented in two separate PRs.