[HYPI-1765] Add support for `children` and bucket selector aggregations

vinted / elasticsearch-dsl-rs

Strongly typed Elasticsearch DSL written in Rust

Apache License 2.0

201 stars 18 forks source link

Closed zcourts closed 3 months ago

buinauskas commented 3 months ago

@zcourts I think GitHub is asking you to make changes on your side.

zcourts commented 3 months ago

I'm not sure what action is needed my end. It says all checks passed and review required. What am I missing?

zcourts commented 3 months ago

@buinauskas any advice? It's not clear what I need to do on this

buinauskas commented 3 months ago

I'm always getting this once I approve the PR.

The merge-base changed after approval.

zcourts commented 3 months ago

This is bizarre, should I close this and reopen a new PR? I've never seen this behaviour on GH before so I'm not sure of the cause or how to fix it

buinauskas commented 3 months ago

@zcourts that would work for me, I've also never seen this before 🙏 and sorry for the delay, I was away for a week.