search

vinteo / hass-opensprinkler

OpenSprinkler Integration for Home Assistant
MIT License
205 stars 40 forks source link

Move name and description to translations #239

Closed EdLeckert closed 1 year ago

EdLeckert commented 1 year ago

Move service name and description strings to translations folder to support new "Translated services" feature in 2023.8.

Not sure that it's compatible with earlier versions of HA, but I believe the settings will stick until overridden, so probably only an issue for new installations of the integration.

Required change to satisfy "hassfest" Action.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vinteo commented 1 year ago

Sorry, on holiday so this is the first time I turned on my laptop in more than a week lol.

Just wanted to confirm that the string have to be removed from the YAML and it cannot be in both places?

EdLeckert commented 1 year ago

Well, your timing is excellent, as I just posted this 2 hours ago.

I thought about leaving them for the case where someone on a back version just adding the integration would need them, but thought the case would be rare. Obviously if we did that it would have to be removed eventually. I doubt there's any reason they couldn't be in both, though.

vinteo commented 1 year ago

Fixes https://github.com/vinteo/hass-opensprinkler/issues/237