search

vinteo / hass-opensprinkler

OpenSprinkler Integration for Home Assistant
MIT License
204 stars 40 forks source link

fix-disable-current-time-by-default #250

Closed EdLeckert closed 11 months ago

EdLeckert commented 11 months ago

Disables sensor.opensprinkler_current_time by default. Addresses Issue #249.

Was planning to remove this entity and replace with a service, but now that it's released I think this is the way to go. Can still add a service later.

We don't need a constant update of the current time, but I have found it to wander in the past unexpectedly, so it's nice to have a way to check periodically.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vinteo commented 11 months ago

should I do a release for this? I am guessing it doesn't help for those who already upgraded though?

EdLeckert commented 11 months ago

I doesn't help those who have already upgraded...they can disable it manually as I explained in Issue #249.

However, for those who have not upgraded, it will save them that trouble, so if it's not too much trouble to release it might be worth it. It's up to you. I've been running with it that way for a month or two and it didn't bother me, but some find it annoying. Two have noticed and reported it so far.

Also know that I'm working on a possible fix for #248. I doubt that many installations are anywhere near as large as this one, but I can't know for sure. My idea is to add an option to Config Flow and Options Flow to not create the Program entities, warning users of the number of entities that would be created. Should have something for you to look at in a day or two.