vinteo / hass-opensprinkler

OpenSprinkler Integration for Home Assistant
MIT License
204 stars 40 forks source link

fix-patch-to-fix-0-23-error #253

Closed EdLeckert closed 11 months ago

EdLeckert commented 11 months ago

Temporary patch to fix "ValueError: hour must be in 0..23" error reported in #252 and #248. Programs using sunset or sunrise start times fail to create entities properly.

Full support of sunrise and sunset times requires a minor update to pyopensprinkler. This patch is to get installations past the error until that work can be done, without requiring an update to pyopensprinkler.

Those using sunset or sunrise will see midnight (00:00:00) as a ..._schedule_start_time until full support is added.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication