search

vinteo / hass-opensprinkler

OpenSprinkler Integration for Home Assistant
MIT License
204 stars 40 forks source link

feat-support-repeating-start-times #265

Closed EdLeckert closed 10 months ago

EdLeckert commented 10 months ago

Feature to complete support for Additional Start Times. Requires py-opensprinkler v0.7.9.

By using Conditional Cards, users can display the appropriate controls, depending on the Start Time Type:

AdditonalStartTimes

Because data in the fields start1-3 is stored differently depending on the Start Time Type, these fields are cleared by py-opensprinkler whenever the type is changed.

The new entities for repeat count and interval are created Disabled to reduce entity bloat for those who do not use Additional Start Times.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vinteo commented 10 months ago

Is this ready to merge into the other branch?

EdLeckert commented 10 months ago

Yes, with the caveat that I have not pulled the code back from your repo and put it on my site yet, but it should be exactly the same