Closed curlydingo closed 7 months ago
Hmm, the linter doesn't seem to like that the new PauseEndTimeSensor has 13 lines of code that match the RainDelayStopTimeSensor.
I could:
Or another option you might come up with? Happy either way just let me know.
Maybe a different icon (might make sense anyway) might help, but not sure if it be enough
Also I didn't give a minor verion for the other service and usually don't for dep upgrade so a patch version might be ok
looks like I forgot to update the vsersion there so it should be 1.2.7 for a patch
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Sorry, only just saw the request for Ed's review! Don't release until he's had a look, I suppose?
Tested against HA 2024.1.2. Looks good.
Thanks, @curlydingo!
@curlydingo I forgot that we should add examples in the README. For the other service as well
Yep, happy to. Might update the tested versions at the top too, unless you object.
Per #218, hopefully better showers for all now :)
I've taken the liberty of incrementing the minor version number, but I'm not sure if that's appropriate or should happen later somehow. Apologies if I got it wrong.