Allow selfsigned certs - Githubissues

yeltnar commented 4 months ago

This is to allow the form that creates the integration with the OpenSprinkler device to have a check box that will disable TLS (SSL) certificate checking so self signed certs can be used.

vinteo commented 4 months ago

Sorry I had it backwards. You are right it should be true. The checkbox label should reflect that as well.

On Tue, May 7, 2024, 1:15 PM yeltnar @.***> wrote:

@.**** commented on this pull request.

In custom_components/opensprinkler/const.py https://github.com/vinteo/hass-opensprinkler/pull/286#discussion_r1591761496 :

@@ -12,6 +12,7 @@ DOMAIN = "opensprinkler"

DEFAULT_NAME = "OpenSprinkler" +DEFAULT_VERIFY_SSL = True

Are you thinking the default state should be allowing non trusted certificates? Just double checking.

— Reply to this email directly, view it on GitHub https://github.com/vinteo/hass-opensprinkler/pull/286#discussion_r1591761496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGID7ZYEW4QQDGA7IPRSP3ZBBBN7AVCNFSM6AAAAABHJM3KJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBRHE4DMNRWGA . You are receiving this because you commented.Message ID: @.***>