search

vintlabs / fauxmoESP

Add voice control of your ESP32 and ESP8266 devices using Amazon Alexa
MIT License
379 stars 70 forks source link

Grouping devices together and trying the On Off button on Alexa App crashes the ESP. #118

Closed Tejas-MD closed 3 years ago

Tejas-MD commented 3 years ago

While I understand that operating through the switches in the Alexa app isn't implemented in this library, I think there should be handling it atleast. Like, if by mistake someone uses that, it is better if the command is ignored voluntarily than abruptly crashing the device... (If this is technically possible).

pvint commented 3 years ago

I do this all the time - for example on my boat I have 8 different fauxmo devices in a group... I have had the same problem, and the real cause was having too much going on in fauxmo.onSetState() - you want to be sure you exit that call as quickly as possible.

pvint commented 3 years ago

Also, see #115 - I think I made a change to do exactly what you want there! I have committed that change in the dev branch - would appreciate if you can give it a try.

Tejas-MD commented 3 years ago

I do this all the time - for example on my boat I have 8 different fauxmo devices in a group... I have had the same problem, and the real cause was having too much going on in fauxmo.onSetState() - you want to be sure you exit that call as quickly as possible.

So this means if the buttons on the Alexa app crash the ESP, it's because of the fauxmo.onSetState() not returning quick? Have you tried to operate it with the on/off buttons after grouping devices in the Alexa app?

pvint commented 3 years ago

Sorry for not having responded to this earlier.

Correct, if onSetState takes too long you can get into trouble. I routinely use it with on/off in groups in the app.