search

vinxi / metrics

Extensible metrics instrumentation with multi-backend reporting
MIT License
2 stars 1 forks source link

feat(#4): support metrics reporting #6

Closed h2non closed 8 years ago

h2non commented 8 years ago

Still needs some features and better test coverage.

This PR basically supports: #3, #4 and initial implementation of InfluxDB reporter.

h2non commented 8 years ago

TravisCI is failing due metrics package is not available in master, therefore go get cannot fetch it.

groyoh commented 8 years ago

I finished my first round of review. It was quite hard to grasp everything so I'd like to review it again tomorrow. @h2non would that be fine with you?

h2non commented 8 years ago

@groyoh I would like to merge this now just to have something usable in master, but I'll keep the branch so tomorrow we can continue with the code review with new improvements.

In any case, I did all the fixes and supported most of your proposals, also with further improvements.