search

vinyldns / go-vinyldns

Go client package for VinylDNS
Apache License 2.0
7 stars 25 forks source link

simplify ZoneUpdate #38

Closed mdb closed 5 years ago

mdb commented 5 years ago

fixes issue #33 and simplifies the ZoneUpdate method.

rhenning commented 5 years ago

While this seems reasonable enough, it changes the arity and interface of a publicly-exported function on the client, thus existing client code that calls ZoneUpdate will fail to compile. Is that OK? A patch-level change usually indicates backward-compatibility. Thoughts?

mdb commented 5 years ago

@rhenning Good eye. Yep, I'm aware of this unfortunate outcome and am comfortable with it, I think. @pauljamescleary and the VinylDNS team have expressed that the major/minor versions stay in sync with those of VinylDNS itself.