This seeks to address issue #9. I am also imagining that it paves a path towards a future where terraform-provider-vinyldns and vinyldns-cli can set custom UserAgents such that usage statistics can be gleaned from logs.
Client{} now has a UserAgent field
NewClientFromEnv() will either look for a VINYLDNS_USER_AGENT env var or set UserAgent to fmt.Sprintf("go-vinyldns %s", Version)
go-vinyldns now has a Version
a make validate-version task errors if the go-vinyldns/version.go's var Version = is not equal to the VERSION cited in the Makefile. While not ideal, it seems necessary to cite the version in two places such that 1) make can generate versioned releases and 2) go-vinyldns can include the version in a default client.UserAgent
bump go-vinyldns patch version. While it's arguably not proper semantic versioning to only bump a patch version on what is ultimately a breaking change that now requires users to set a client.UserAgent, go-vinyldns should stay in lock step major/minor versioning with vinyldns itself, per agreement.
atecce
commented
5 years ago
This seeks to address issue #9. I am also imagining that it paves a path towards a future where
terraform-provider-vinyldnsandvinyldns-clican set customUserAgents such that usage statistics can be gleaned from logs.Client{}now has aUserAgentfieldNewClientFromEnv()will either look for aVINYLDNS_USER_AGENTenv var or setUserAgenttofmt.Sprintf("go-vinyldns %s", Version)go-vinyldnsnow has aVersionmake validate-versiontask errors if thego-vinyldns/version.go'svar Version =is not equal to theVERSIONcited in theMakefile. While not ideal, it seems necessary to cite the version in two places such that 1)makecan generate versioned releases and 2)go-vinyldnscan include the version in a defaultclient.UserAgentgo-vinyldnspatch version. While it's arguably not proper semantic versioning to only bump a patch version on what is ultimately a breaking change that now requires users to set aclient.UserAgent,go-vinyldnsshould stay in lock step major/minor versioning withvinyldnsitself, per agreement.