search

vinyldns / go-vinyldns

Go client package for VinylDNS
Apache License 2.0
7 stars 25 forks source link

Fix for issue #43 #44

Closed com-m closed 5 years ago

com-m commented 5 years ago

Description of the Change

The recordchange struct, when encoded into json, used to produce a field named "data", it now produces a field named "record"

Why Should This Be In The Package?

The current version does not exhibit expected behavior when making batch changes. This change resolves that.

Benefits

Fixes a bug

Applicable Issues

43

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

com-m commented 5 years ago

Yes, the change is in the record attribute, I can add tests to ensure Record is set to the correct value.

com-m commented 5 years ago

I added the test in a second commit

megadeezl commented 5 years ago

Any ETA on merging this?

megadeezl commented 5 years ago

Any updates on this PR?

mdb commented 5 years ago

@megadeezl I apologize; I have been swamped and completely overlooked your commit and updates. Thanks so much!