Correct Algorithm type in Record

jhg03a commented 4 years ago

The VinylDNS API returns the algorithm field as an integer instead of a string on DS records.

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

Why Should This Be In The Package?

This fixes the new support for DS recordset types for DNSSEC.

Benefits

Consumers will be able to unmarshal recordsets that include the DS type.

Possible Drawbacks

None

Verification Process

I used this modification in a separate project that consumed an large DNS Zone of great diversity in use cases without an issue. Before it was reproducible failure, now it works fine.

Applicable Issues (Optional)

Fixes #71

jhg03a commented 4 years ago

The integration tests don't appear to work on OSX.

mdb commented 4 years ago

The integration tests don't appear to work on OSX.

@jhg03a Apologies for the silence -- I've been traveling. Could you please elaborate a bit on how the tests fail to work on OSX? I believe they work as expected on my laptop.

jhg03a commented 4 years ago

I observed that it's trying to setup the VinylDNS API containers in specific GOPATH that doesn't exist in protected OSX directories and tries to invoke docker with commands that didn't seem to work.

mdb commented 4 years ago

@jhg03a Interesting -- thanks for clarifying. It sounds like this warrants an issue in and of itself? If so, would you mind including details and/or output?

vinyldns / go-vinyldns