Closed jhg03a closed 4 years ago
The integration tests don't appear to work on OSX.
The integration tests don't appear to work on OSX.
@jhg03a Apologies for the silence -- I've been traveling. Could you please elaborate a bit on how the tests fail to work on OSX? I believe they work as expected on my laptop.
I observed that it's trying to setup the VinylDNS API containers in specific GOPATH that doesn't exist in protected OSX directories and tries to invoke docker with commands that didn't seem to work.
@jhg03a Interesting -- thanks for clarifying. It sounds like this warrants an issue in and of itself? If so, would you mind including details and/or output?
The VinylDNS API returns the algorithm field as an integer instead of a string on DS records.
Requirements
Description of the Change
Why Should This Be In The Package?
This fixes the new support for DS recordset types for DNSSEC.
Benefits
Consumers will be able to unmarshal recordsets that include the DS type.
Possible Drawbacks
None
Verification Process
I used this modification in a separate project that consumed an large DNS Zone of great diversity in use cases without an issue. Before it was reproducible failure, now it works fine.
Applicable Issues (Optional)
Fixes #71