Update dependencies to use Go 1.21 & support VinylDNS 0.20.0

brucedewald commented 5 months ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

I plan to submit a PR to terraform-provider-vinyldns in the near future to add some features, but before adding any functionality, I wanted to get this repo & terraform-provider-vinyldns in good shape. This PR should not be changing any functionality, just updating several things as described here:

Updating to use go 1.21 from 1.17 which was EOL'd in Aug 2022
Replacing deprecated go-aws-auth package with the official AWS SDK for AWS SigV4 signing of requests
Replacing deprecated ioutil package with io/os as appropriate
Updated Makefile to use latest version of VinylDNS for integration testing
Following changes to support version 0.20.0 of VinylDNS
- Updated Makefile to properly start/stop test containers
- Updating RecordSetChanges calls to set startfrom & nextID to be integers instead of strings
- Minor changes to tests to reflect current state of VinylDNS

Note: I'm not sure if I should be bumping the version of this package as part of this PR?

I will also be submitting a similar PR to terraform-provider-vinyldns in the very near future with similar updates.

Why Should This Be In The Package?

To ensure this package doesn't get further out of date.

Benefits

Support of current VinylDNS and using stable version of Go.

Possible Drawbacks

None to my knowledge.

Verification Process

Ran make all which does go test and then spins up docker container with VinylDNS 0.20.0 and does integration testing.

~ make all
test -z ""
go vet ./...
GO111MODULE=on go test ./... -cover
ok      github.com/vinyldns/go-vinyldns/vinyldns        0.375s  coverage: 84.6% of statements
GO111MODULE=on go build -ldflags "-X main.version=0.9.16" ./...
/Users/bdewald/go/1.21.9/src/github.com/vinyldns/vinyldns-0.20.0/quickstart/quickstart-vinyldns.sh \
                --clean
Killing running containers...
76382067785c
ea00febbe124
Removing containers...
76382067785c
ea00febbe124
Deleted Networks:
vinyldns_net

Clean up completed!
if [ ! -d "/Users/bdewald/go/1.21.9/src/github.com/vinyldns/vinyldns-0.20.0" ]; then \
                echo "github.com/vinyldns/vinyldns-0.20.0 not found in your GOPATH (necessary for acceptance tests), getting..."; \
                git clone \
                        --branch v0.20.0 \
                        https://github.com/vinyldns/vinyldns \
                        /Users/bdewald/go/1.21.9/src/github.com/vinyldns/vinyldns-0.20.0; \
        fi
/Users/bdewald/go/1.21.9/src/github.com/vinyldns/vinyldns-0.20.0/quickstart/quickstart-vinyldns.sh \
                --api \
                --version-tag 0.20.0
Starting VinylDNS (latest) the background...
[+] Running 2/0
[+] Running 2/5ldns_net                                                                                                                                       Created0.1s 
[+] Running 3/5ldns_net                                                                                                                                       Created0.2s 
[+] Running 4/5ldns_net                                                                                                                                       Created0.3s 
 ⠸ Network vinyldns_net                                                                                                                                       Created0.4s 
 ✔ Container vinyldns-api-integration                                                                                                                         Started0.2s 
 ! integration The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested        0.0s 
 ✔ Container vinyldns-api                                                                                                                                     Started0.3s 
 ! api The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested                0.0s 

Waiting for VinylDNS API at http://localhost:9000 ................OK

VinylDNS API started! You can connect to the API via http://localhost:9000
To clean up the running containers:
    /Users/bdewald/go/1.21.9/src/github.com/vinyldns/vinyldns-0.20.0/quickstart/quickstart-vinyldns.sh --clean
GO111MODULE=on go test ./... -tags=integration
ok      github.com/vinyldns/go-vinyldns/vinyldns        43.921s
cat vinyldns/version.go | grep 'var Version = "0.9.16"'
var Version = "0.9.16"
GO111MODULE=on go install ./...

Applicable Issues (Optional)

N/A

CLAassistant commented 5 months ago

All committers have signed the CLA.

Aravindh-Raju commented 4 months ago

@brucedewald, we will wait for other's review and decide if the above changes were necessary except for changing the startFrom type from any to int.

brucedewald commented 4 months ago

Thank you @Aravindh-Raju @Jay07GIT for your reviews & approvals - what is needed to get this PR merged and a new release tag published?

brucedewald commented 4 months ago

@Aravindh-Raju @Jay07GIT - I wanted to follow up on my previous comment to see if you could provide any guidance here, thanks! Another PR is pending on a new release being created from this one: https://github.com/vinyldns/terraform-provider-vinyldns/pull/116

Additionally, I plan to submit 1 or more feature PRs once this initial "clean up" work is done. Thank you!

brucedewald commented 3 months ago

Thanks @nspadaccino - All commits show as verified now

vinyldns / go-vinyldns