Closed brucedewald closed 3 months ago
@brucedewald, we will wait for other's review and decide if the above changes were necessary except for changing the startFrom type from any
to int
.
Thank you @Aravindh-Raju @Jay07GIT for your reviews & approvals - what is needed to get this PR merged and a new release tag published?
@Aravindh-Raju @Jay07GIT - I wanted to follow up on my previous comment to see if you could provide any guidance here, thanks! Another PR is pending on a new release being created from this one: https://github.com/vinyldns/terraform-provider-vinyldns/pull/116
Additionally, I plan to submit 1 or more feature PRs once this initial "clean up" work is done. Thank you!
Thanks @nspadaccino - All commits show as verified now
Requirements
Description of the Change
I plan to submit a PR to terraform-provider-vinyldns in the near future to add some features, but before adding any functionality, I wanted to get this repo & terraform-provider-vinyldns in good shape. This PR should not be changing any functionality, just updating several things as described here:
Note: I'm not sure if I should be bumping the version of this package as part of this PR?
I will also be submitting a similar PR to terraform-provider-vinyldns in the very near future with similar updates.
Why Should This Be In The Package?
To ensure this package doesn't get further out of date.
Benefits
Support of current VinylDNS and using stable version of Go.
Possible Drawbacks
None to my knowledge.
Verification Process
Ran
make all
which does go test and then spins up docker container with VinylDNS 0.20.0 and does integration testing.Applicable Issues (Optional)
N/A