vinzscam / backstage-chart

Backstage Helm Chart
27 stars 10 forks source link

Support for Postgres Subchart? #1

Closed ChrisJBurns closed 1 year ago

ChrisJBurns commented 2 years ago

As discussed on this issue: #4945 it may be worth adding a Postgres Subchart that users can enable/disable via the values.yaml.

I've got a POC working for this, and I've even implemented an externalDatabase aspect which allows you to just configure Backstage with postgres details that are external to the chart (which I've not tested). Is this something you'd be interested in me adding? Can put up the PR shortly if so.

vinzscam commented 2 years ago

sounds good @ChrisJBurns! 🚀

ChrisJBurns commented 2 years ago

Shall push it up today and open a PR.

ChrisJBurns commented 2 years ago

Am ok to close this @vinzscam ? As https://github.com/vinzscam/backstage-chart/pull/2 has been merged :+1:

cmoulliard commented 2 years ago

As the PR has been merged, I propose to close it. WDYT ? @ChrisJBurns

vinzscam commented 1 year ago

Closed by #2