search

violet-php / streaming-json-encoder

PHP library for iteratively encoding large JSON documents piece by piece
http://violet.riimu.net
MIT License
314 stars 16 forks source link

Add support for php 7.3 and 7.4 #3

Closed snapshotpl closed 3 years ago

Gunni commented 4 years ago

An error in a file you didn't change?

FILE: ...is/build/violet-php/streaming-json-encoder/tests/tests/JsonEncoderTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 274 | ERROR | [x] Expected 0 spaces after reference operator for argument
     |       |     "$actualTokens"; 1 found
Riimu commented 4 years ago

That's caused due to update in the linting tools used on the CI. The versions aren't locked down, so small discrepancies like this can happen. I'll addess this in few days.

snapshotpl commented 3 years ago

Something is wrong with travis status notification... Build here https://travis-ci.org/github/violet-php/streaming-json-encoder/builds/741246264

snapshotpl commented 3 years ago

Travis passed, Scrutinizer fails by some timeout but I think is ready to merge