violin-suzutsuki / LinoriaLib

MIT License
51 stars 315 forks source link

Resizeable Window variable & one fix. #28

Closed mstudio45 closed 1 year ago

mstudio45 commented 1 year ago
[ Fixed ]
+ Tab ScrollingFrame didn't resize properly with Config.Size (now it does)

[ Added ]
+ Resizeable variable in CreateWindow() function. This variable will make the window resizeable.

With Resizeable set to true:

violin-suzutsuki commented 1 year ago

this feature is really nice but unfortunately it messes with the groupboxes - issue also happens when Resizeable = false: https://imgsli.com/MTc1MDM1

mstudio45 commented 1 year ago

Oh I see, Im going to fix the Groupboxes size and the issue, and make a new pull reuqest.

mstudio45 commented 1 year ago

@violin-suzutsuki I have fixed the GroupBox size issue (its now accurate to the main release) and the Resizeable = false issue. I also added na "Delete Config" button to the SaveManager.lua

violin-suzutsuki commented 1 year ago

@mstudio45 thanks, the groupboxes are the correct size now but unfortunately still looks like there are a few issues: screen1 screen2

mstudio45 commented 1 year ago

My bad let me fix it real quick.

mstudio45 commented 1 year ago

@violin-suzutsuki Fixed it, try now. If it doesn't work try waiting like 5 minutes for Github to update the raw link. I will fix it tommorow because I don't have time today if it doesn't work even after you have waited.

violin-suzutsuki commented 1 year ago

@mstudio45 yeah that stuff is fixed now, there's just some weird stuff with dropdowns not resizing properly and sometimes not even opening at all - might just be an issue with how dropdowns were implemented since the library wasn't built with scaling in mind: dropdown

if you're not sure what the issue is feel free to merge into the dev branch instead and i can take a look

mstudio45 commented 1 year ago

If you want you can find any bugs and I will fix them for you and then when its working fine you can merge this pull request to main. Also i will fix the dropdowns tommorow on my PC.

mstudio45 commented 1 year ago

@violin-suzutsuki I have fixed the dropdowns. The issue was the list frame wasn't resizing when the dropdown opened. But there is one issue. The button is not large enough and I don't know whats happening because there is nothing wrong. That issue only happens on normal dropdowns without a SpecialType. I will update you if I will fix that. Thanks also for checking out this pull request!

I have also added ClearTextOnFocus for the AddInput function.

mstudio45 commented 1 year ago

Made Keybinds not work if you are typing in chat or any other textbox.

violin-suzutsuki commented 1 year ago

merged into dev for the moment

violin-suzutsuki commented 1 year ago

@mstudio45 think i have got everything working on the dev branch, sliders & dropdowns seem to be fixed

mstudio45 commented 1 year ago

Okay!