search

violines / rest-bundle

Symfony Bundle to create REST APIs
MIT License
35 stars 1 forks source link

Remove or Update Rector #134

Open HellPat opened 3 years ago

HellPat commented 3 years ago

rectorphp/rector is not used, no Rector rules are used.

Do you want to use it in the future?

If so, todays release looks nice :-) https://getrector.org/blog/2021/03/22/rector-010-released-with-php71-support

Dependencies resolve, so it should be an easy pick -> I'd suggest to configure some Rules and integrate it in the CI (should be done with a vendor/bin/rector process src --dry-run) https://github.com/violines/rest-bundle/blob/87694bf0ab1f2567735de67b2b81a050ce160d48/composer.json#L24

simon-schubert commented 3 years ago

hey @HellPat i played a bit around with it and left the basic setup in. If you have useful ideas, please add them. And yes would be nice to run it in CI.

Thanks!