search

vionya / discord-rich-presence

A cross-platform Discord Rich Presence library written in Rust
MIT License
89 stars 16 forks source link

General refactoring #24

Closed Tofixrs closed 1 year ago

Tofixrs commented 1 year ago

Some refactors i made This pr will be followed by another one wich adds some QOL features like better error handling (handles error on handshake and set_activity) I was also thinking of revamping the error handling completly so we get error context instead of Box and will do that if sardonicism-04 agrees on that

Tofixrs commented 1 year ago

This pr should probably bump version to 1.0 since it has breaking changes

vionya commented 1 year ago

Hey, I appreciate the PR!

I like most of the changes here. However, some of the code changes conflict with in-progress code that I'm working on for a major breaking release. Because of that, I would prefer to re-implement them on top of my existing changes.

If that's alright, I'll still credit you in the release notes when I finish my changes :)

Bowarc commented 1 year ago

Any news ?

vionya commented 1 year ago

Incorporated a lot of changes into the dev branch

Tofixrs commented 1 year ago

If that's alright, I'll still credit you in the release notes when I finish my changes :)

Nah no need to