Serilog 4 - Githubissues

vip32 / serilog-sinks-litedb

Apache License 2.0

33 stars 15 forks source link

Serilog 4 #18

Closed marklam closed 3 months ago

marklam commented 3 months ago

Updated package dependencies on LiteDB and Serilog

Periodic batching is in the core Serilog
Literate is now the default for Console logging (in test project)

marklam commented 3 months ago

I assume the build failure is build-pipeline related to changing the platforms to match Serilog 4, but I don't have access to see the full build logs.

vip32 commented 3 months ago

Yes some frameworks are missing during build. Please remove the .net4 targets, no support for those. Only core 6, 7, 8. a github actions pipeline will make this more transparent. Lets move away from azure devops pipeline.

marklam commented 3 months ago

Is there any reason not to cut the frameworks down to netstandard 2.0? I had just copied the set that serilog used, for consistency.

vip32 commented 3 months ago

no particular reason, just don't want to bother with classic stuff (for example pipelines). net6, 7 + 8 will do just fine nowadays. and netstandard 2 of course

vip32 commented 3 months ago

ah, now i see. net45;netstandard2.0 where the original targets in this repo. let's continue with your proposal. that means the build pipeline needs to be adjusted for .net 6, 7 + 8 (UseDotNet)

vip32 commented 3 months ago

please rebase from master. build pipeline has been adjusted for new targetframeworks.

vip32 commented 3 months ago

Serilog 4 does not support net45 anymore, so it can be removed as targetframework. Please also let netstandard2 in there. Build currently fails at restore step due to serilog 4 & net45

marklam commented 3 months ago

It takes 3 minutes to fail now, so I guess it's a different problem?

vip32 commented 3 months ago

build is fine now, however nuget apikey has expired. let me fix that...