viper-framework / viper

Binary analysis and management framework
Other
1.54k stars 353 forks source link

Make result from 'file' command a string #714

Closed toomanybananas closed 5 years ago

toomanybananas commented 5 years ago

If import magic fails, viper will use the output of the file command to determine the filetype. However, the returned value is a byte string instead of a string, which breaks some functionality (including yara scanning). This PR fixes that.

botherder commented 5 years ago

Thanks.