toomanybananas commented 5 years ago

Currently, uploading a file to the web UI does not run the autoruns module on newly uploaded samples. This PR fixes that issue.

Additionally, the code at https://github.com/viper-framework/viper/blob/master/viper/web/viperweb/views.py#L277 may be dead code - it should be running the autoruns on newly uploaded samples, but it does not appear to do that (I think this PR is still required to fix the underlying issue, as the code in viperweb will not be called when uploading an archive, which we still want to run autoruns on).

codecov-io commented 5 years ago

Codecov Report

Merging #718 into master will decrease coverage by <.01%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
- Coverage   40.56%   40.56%   -0.01%     
==========================================
  Files         129      129              
  Lines       12683    12686       +3     
==========================================
+ Hits         5145     5146       +1     
- Misses       7538     7540       +2

Impacted Files	Coverage Δ
viper/web/viperapi/views.py	`49.89% <33.33%> (-0.11%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc0b1e1...66d5e55. Read the comment docs.

frennkie commented 5 years ago

The function add_file is used in class UrlDownloadView (https://github.com/viper-framework/viper/blob/master/viper/web/viperweb/views.py#L342) and therefore - currently - not dead code.

I would prefer cfg.get('autorun').enabled over __config__.get('autorun').enabled.

Otherwise this looks OK to me..

viper-framework / viper

Make API run autoruns on newly uploaded files #718

Codecov Report