viper-framework / viper

Binary analysis and management framework
Other
1.54k stars 351 forks source link

Added new command to parse out dll names under the pe command. #722

Closed xorhex closed 5 years ago

xorhex commented 5 years ago

Tried to copy the style as best I could. Let me know of any deviations, and I'll correct and re-submit.

botherder commented 5 years ago

I might be missing something, but isn't this a duplicate of the pe exports command?

xorhex commented 5 years ago

Wasn't able to duplicate the functionality when using the pe exports command but I'm no viper expert.

If the file is a dll, it pulls out the name of the dll itself, not the dll exports names.

return "{0}".format(pe.DIRECTORY_ENTRY_EXPORT.name)

codecov-io commented 5 years ago

Codecov Report

Merging #722 into master will decrease coverage by 0.13%. The diff coverage is 7.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage    40.6%   40.47%   -0.14%     
==========================================
  Files         129      129              
  Lines       12682    12733      +51     
==========================================
+ Hits         5150     5154       +4     
- Misses       7532     7579      +47
Impacted Files Coverage Δ
viper/modules/pe.py 31.31% <7.84%> (-1.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9d1bea...4b1cac9. Read the comment docs.

botherder commented 5 years ago

Oh I see. I just skimmed at the commit too quickly.

botherder commented 5 years ago

Thanks.