search

viper-framework / viper

Binary analysis and management framework
Other
1.54k stars 353 forks source link

Git-based dependencies not working through PyPi install #754

Closed botherder closed 4 years ago

botherder commented 5 years ago

While using pip3 install . inside Viper's folder works fine, installing through PyPi does not work and fails with the following error:

ERROR: Could not find a version that satisfies the requirement PyTaxonomies (from viper-framework) (from versions: none)
ERROR: No matching distribution found for PyTaxonomies (from viper-framework)

We need to investigate how to make this work, so we can wrap up 2.0 and finally release on PyPi.

Rafiot commented 5 years ago

Hmmm right, I need to do an actual release on PyPi then.

I'll work on it asap. When do you want to tag v2.0? The dirty fast fix is to make that optional: none of the git-based deps are critical.

botherder commented 5 years ago

I'd prefer to figure out a way to make it work, cause I imagine other dependencies that are not MISP-related will cause the same issue.

botherder commented 4 years ago

I thought I had resolved, but this is still not working when uploading to PyPi:

HTTPError: 400 Client Error: Invalid value for requires_dist. Error: Can't have direct dependency: 'PyMISPGalaxies @ git+https://github.com/MISP/PyMISPGalaxies.git#egg=PyMISPGalaxies' for url: https://upload.pypi.org/legacy/

botherder commented 4 years ago

Ultimately I think we can't have a PyPi package that depends on non-PyPi packages.

Rafiot commented 4 years ago

You're probably right.

I really need to packages these dependencies. But as I cannot really give a timeline for that, I'll probably make these ones optional so we can release a package.

botherder commented 4 years ago

What do you think about #767. In that way we could keep a viper package to a core, and then use git+pip commands from Viper to download and install modules.

Rafiot commented 4 years ago

Yep, 100% agree.

botherder commented 4 years ago

Closing this ticket as I started work on #767.