Closed botherder closed 4 years ago
Hmmm right, I need to do an actual release on PyPi then.
I'll work on it asap. When do you want to tag v2.0? The dirty fast fix is to make that optional: none of the git-based deps are critical.
I'd prefer to figure out a way to make it work, cause I imagine other dependencies that are not MISP-related will cause the same issue.
I thought I had resolved, but this is still not working when uploading to PyPi:
HTTPError: 400 Client Error: Invalid value for requires_dist. Error: Can't have direct dependency: 'PyMISPGalaxies @ git+https://github.com/MISP/PyMISPGalaxies.git#egg=PyMISPGalaxies' for url: https://upload.pypi.org/legacy/
Ultimately I think we can't have a PyPi package that depends on non-PyPi packages.
You're probably right.
I really need to packages these dependencies. But as I cannot really give a timeline for that, I'll probably make these ones optional so we can release a package.
What do you think about #767. In that way we could keep a viper package to a core, and then use git+pip commands from Viper to download and install modules.
Yep, 100% agree.
Closing this ticket as I started work on #767.
While using
pip3 install .
inside Viper's folder works fine, installing through PyPi does not work and fails with the following error:We need to investigate how to make this work, so we can wrap up 2.0 and finally release on PyPi.