viperML / nh

Yet another nix cli helper
European Union Public License 1.2
1.02k stars 35 forks source link

Return with exit code when --ask is not accepted #146

Closed Jeidnx closed 2 months ago

Jeidnx commented 3 months ago

This change exits the program with code 1 when the user rejects changing to the new configuration. The motivation behind this change is to make it easier to wrap this program in scripts.

As i have written in the code, i wanted to propagate the error properly but with color_eyre this doesn't seem to be an option.

I was also a bit confused what drop(out_dir) was doing there and couldn't understand the comment, so i changed it to something more clear.

Jeidnx commented 2 months ago

I've made the requested change and also split the changes into two commits.

viperML commented 2 months ago

Can you apply the same src/home.rs and src/clean.rs? Then it should be ready

Jeidnx commented 2 months ago

Of course, done