search

viperet / vscode-magento-wizard

Helps develop Magento 2 extensions using VSCode
36 stars 16 forks source link

Added Recently Used to inject dependency action #8

Closed NetStorm84 closed 4 years ago

NetStorm84 commented 4 years ago

I use the Inject dependecy feature quite a bit and thought it would be handy to have the most used items always show.

So I have added this bit of code to have the last 5 items set as 'alwaysShow' in the quickPick.

viperet commented 4 years ago

@NetStorm84 I accepted your PR, but in my opinion, it requires some changes. I would like to have this functionality in other Quick Picks too so it should probably be moved into createQuickPickCustom(). But most important - I'd like to remove 'alwaysVisible' on Recently Used items and just display them on the top of the list. What do you think?

NetStorm84 commented 4 years ago

@NetStorm84 I accepted your PR, but in my opinion, it requires some changes. I would like to have this functionality in other Quick Picks too so it should probably be moved into createQuickPickCustom(). But most important - I'd like to remove 'alwaysVisible' on Recently Used items and just display them on the top of the list. What do you think?

Absolutely. This can definatly be improved. I think something more like the actual CommandQuick pick, this has a serperate section at the top for recently used items.

viperet commented 4 years ago

@NetStorm84 do you know how to create such QuickPick with a separate section from extension?

viperet commented 4 years ago

@NetStorm84 'Recently Used' feature added in v2.2.2, thanks for the contribution!

NetStorm84 commented 4 years ago

No. This is my first experience with both VScode Development and Typescript.

On Tue, 11 Feb 2020, 14:31 Vitaly Peretiatko, notifications@github.com wrote:

@NetStorm84 https://github.com/NetStorm84 do you know how to create such QuickPick with a separate section from extension?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/viperet/vscode-magento-wizard/pull/8?email_source=notifications&email_token=AAXMTYM2CKGUAX543H2NUR3RCKZDXA5CNFSM4KSDBCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELMT6RI#issuecomment-584662853, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXMTYOYZEZX7FKO2XVEMJ3RCKZDXANCNFSM4KSDBCDA .