search

viperproject / chalice2silver

Other
0 stars 0 forks source link

Issue annotations may only be marked as "silicon" issues #54

Closed viper-admin closed 4 years ago

viper-admin commented 10 years ago

Created by bitbucket user ykass on 2014-08-20 13:48 Last updated on 2015-07-14 08:04

This is probably a problem in the error annotation system implemented in Silver.

When testing, using sbt test, an error annotation is taken into consideration by the testing framework only if it is annotated as a silicon issue, e.g.,

#!

//:: UnexpectedOutput(whatever.whatnot, /silicon/issue/2014/)

On the contrary, an annotation like the following will be ignored

#!

//:: UnexpectedOutput(whatever.whatnot, /chalice2sil/issue/2014/)

The temporary solution is to use silicon annotations for every problem. However, most numbers refer to Chalice2Silver issues. If the issue does not actually belong to Chalice2Silver, a nearby comment will point to the correct module.

viper-admin commented 9 years ago

@vakaras commented on 2015-07-09 08:56

Fixed by commits https://github.com/viperproject/chalice2silver/commit/366872b0607e28877005dc9b55cffb25968565f6 (Chalice2Silver) and 53d855d900de626ead6f86a10a10eaf811675542 (Silver).

viper-admin commented 9 years ago

@mschwerhoff on 2015-07-14 08:04:

  • changed state from new to resolved