search

viperproject / prusti-dev

A static verifier for Rust, based on the Viper verification infrastructure.
http://prusti.org
Other
1.52k stars 103 forks source link

Update dependencies (rustc nightly-2023-07-15) #1430

Closed vakaras closed 11 months ago

vakaras commented 11 months ago

@Aurel300 Your turn.

vakaras commented 11 months ago

@Aurel300 What is the status of this?

Aurel300 commented 11 months ago

@vakaras Can you reproduce the error? Locally, when testing error_position.rs, I get the expected error locations, but on the CI they are one line off, it seems?

fpoli commented 11 months ago

@vakaras Can you reproduce the error? Locally, when testing error_position.rs, I get the expected error locations, but on the CI they are one line off, it seems?

Did you re-download the viper_tools? Maybe it'd due to a change in Viper and you still have the old JARs.

Aurel300 commented 11 months ago

Ah, I actually did not, my bad!

fpoli commented 11 months ago

It would actually be nice to make x.py auto-update the viper_tools when viper-toolchain changes... Adding a metadata file with the tag into all released Viper zip packages would be one way to do that.

vakaras commented 11 months ago

@Aurel300 What is the status of this?

Aurel300 commented 11 months ago

@vakaras I am still waiting for #1434: I see viper-sys is failing to build in the PR. Do you want me to take over that PR as well? Otherwise, this is either blocked or we don't upgrade the Viper version yet.

vakaras commented 11 months ago

@vakaras I am still waiting for #1434: I see viper-sys is failing to build in the PR. Do you want me to take over that PR as well? Otherwise, this is either blocked or we don't upgrade the Viper version yet.

Marco is still working on it, so I would suggest not updating Viper.

vakaras commented 11 months ago

It would actually be nice to make x.py auto-update the viper_tools when viper-toolchain changes... Adding a metadata file with the tag into all released Viper zip packages would be one way to do that.

You do not need to put the meta-data into the ZIP file. It should be sufficient to just change x.py setup to copy viper_toolchain to viper_tools folder after a successful update.