search

vipickering / mastr-cntrl

A Micropub Microservice
MIT License
26 stars 2 forks source link

Sending webmentions is looping still broken #62

Closed vipickering closed 5 years ago

vipickering commented 5 years ago

There appears to be something wrong with sending webmentions again. Invesitage.

vipickering commented 5 years ago

This looks like another date mis-match. This time on Netlify end

vipickering commented 5 years ago

Tracked down the problem. Previously I fixed the wrong dates being matched. That is still working ok. What is actually happening is that the two times being compared are slightly different. One has the GMT offset. The other does not.

Dates appears to be a bad idea to use as a comparison. I never know what it will be and coding around it is becoming complicated. Time to take a different path.

In the meantime, I'll disable sending webmentions

vipickering commented 5 years ago

Worked out all the bugs.

1) Time was not being save in the correct encoded string. -T was used intstead of just T. Also it was missing the offset, as mentioned above. 2) I changed the code on Mastr Cntrl instead of working on the server datetime (because it was in a different timezone) to being derived from the time of the post. This made sense but, has broken the ability for the publish time to increase; causing the loop to be never ending. The site never updates itself to be ahead because it always calculates the same time. This is written to the YAML file repeatedly which is always less than the previous time and loops endlessly.

vipickering commented 5 years ago

I've corrected 1 and 2. The time is now created correctly and saved in the right format. I am going to keep my eye on this for a little while before closing the ticket.

vipickering commented 5 years ago

Fixed this now I think.

I now take the return URL and using MomentJs turn it back in to datetime stamp in the Jekyll format. I then add 1 minute (this will also account for the 59 mins + 1 min) scenario. Then POST back to the file with the updated date.